BCDA-7900: Add integration test validation for opt-out import #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
changed the title
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
|
functionality is working as expected, but the dev env lambda is occasionally getting to the test file before the test lambda does, which is resulting in integration test failures. Success run: https://github.com/CMSgov/bcda-app/actions/runs/9879612164/job/27286247165 |
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
GitHub Actions
Inactive
kyeah
added a commit
that referenced
this pull request
Jul 11, 2024
…ic subfolders (#974) ## 🎫 Ticket https://jira.cms.gov/browse/BCDA-7900 ## 🛠 Changes - Update dev/test CCLF and Opt Out S3 Importers to only import specific subfolders ## ℹ️ Context As part of improving integration tests, it was observed that dev and test were competing for the same files in BFD Test S3. This changes the app code for those environments to avoid competition and only look for files in environment-relevant subfolders (e.g. `bcda/in/test/` instead of `bcda/in/`.) ## 🧪 Validation See #963 for successful tests, yay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-7900
🛠 Changes
Integration testing for opt-out lambda has had additional steps added:
ℹ️ Context
Integration testing is required to ensure that future changes will not break existing functionality and that the opt-out lambda is working as expected.
🧪 Validation
Ran using happy and unhappy paths. Validated that sensitive data is not printed to stderr or stdout in the event of an issue.